Expand constraint on Faraday gem to allow for version 0.17.3#42
Merged
michaelklishin merged 1 commit intoruby-amqp:masterfrom Mar 5, 2020
Merged
Conversation
hatch-carl
force-pushed
the
unconstrain-faraday-to-0-17-3
branch
from
64f7db4 to
adea4e6
Compare
michaelklishin
approved these changes
Mar 5, 2020
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Faraday has recently released 1.0, and faraday_middleware is progressing that direction too. I'd like to upgrade these dependencies, and there does not seem to be any obstacle for this gem to allow its consumers to do so.
Regarding the decision on constraints, I chose
1as the upper bound. Faraday_middleware's constraints do not yet permit version 1 of faraday. Version 0.17.3 is the highest version currently reachable by this constraint. That version introduces optional deprecation warnings useful to developers wishing to prepare the way to upgrade to 1.0, so it seemed a good point.