Skip to content

Bumping all gems to newest versions#45

Merged
michaelklishin merged 1 commit intoruby-amqp:masterfrom
nielsjansendk:gem-version-bump-22042020
Apr 22, 2020
Merged

Bumping all gems to newest versions#45
michaelklishin merged 1 commit intoruby-amqp:masterfrom
nielsjansendk:gem-version-bump-22042020

Conversation

@nielsjansendk
Copy link
Copy Markdown
Contributor

Bumping gems to the following versions:

rspec to version 3.9
bunny to version 2.15.0
hashie to version 4.1
multi_json to version 1.14.1
faraday to version 1.0.1
faraday-middleware to version 1.0

Copy link
Copy Markdown
Member

@michaelklishin michaelklishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please back out all change log updates.

### Meaningful Exceptions for 4xx and 5xx Responses

`4xx` and `5xx` responses now will result in meaningful exceptions
being raised. For example, `404` responses will raise `Faraday::Error::ResourceNotFound`.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot retroactively edit a change log entry for 0.4.0

michaelklishin added a commit that referenced this pull request Apr 22, 2020
@michaelklishin michaelklishin merged commit 3de88c2 into ruby-amqp:master Apr 22, 2020
@michaelklishin
Copy link
Copy Markdown
Member

I undid the changelog change and added a new changelog entry with a mention of the exception class change. Thank you!

This was referenced Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants