Skip to content

Add support for if-unused and if-empty for delete_queue#62

Merged
michaelklishin merged 3 commits intoruby-amqp:mainfrom
BranchIntl:delete_queue_if_unused_if_empty
Jan 29, 2024
Merged

Add support for if-unused and if-empty for delete_queue#62
michaelklishin merged 3 commits intoruby-amqp:mainfrom
BranchIntl:delete_queue_if_unused_if_empty

Conversation

@shashankmehra
Copy link
Copy Markdown
Contributor

@shashankmehra shashankmehra commented Jan 29, 2024

From HTTP API docs

When DELETEing a queue you can add the query string parameters if-empty=true and / or if-unused=true. These prevent the delete from succeeding if the queue contains messages, or has consumers, respectively.

This PR adds supports for providing these query parameters and the tests to confirm the behaviour.

@michaelklishin
Copy link
Copy Markdown
Member

According to the diff, this PR does modify some existing tests and that's it.

@michaelklishin
Copy link
Copy Markdown
Member

Hm, now I see more recent changes, not sure what happened to the Files changes tab.

@michaelklishin michaelklishin merged commit 29ecbce into ruby-amqp:main Jan 29, 2024
@michaelklishin
Copy link
Copy Markdown
Member

Thank you!

@michaelklishin michaelklishin added this to the 2.3.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants