feat: update dependencies#67
Merged
michaelklishin merged 1 commit intoruby-amqp:mainfrom Oct 23, 2025
Merged
Conversation
Updates dependencies to their latest version. Verified tests locally, all work. Signed-off-by: Frederik Thuysbaert <frederik.thuysbaert@combell.group>
Member
|
@fretb thank you. How soon do you need a new release to be published to rubygems.org? |
Contributor
Author
Hi @michaelklishin, the sooner the better. I'm using this in combination with Cinc Client, which since the newest release has a conflicting dependency. Thanks! |
Merged
fretb
added a commit
to fretb/rabbitmq_http_api_client
that referenced
this pull request
Nov 5, 2025
In ruby-amqp#67, I proposed to update the dependency constraints to allow the gem to be compatible with newer gem versions. I now see that what I did was wrong, while no code changes were done (meaning that the dependency constraints as they were would still work), I made the gem conflict with working gem versions. I updated the constraints to reflect what I was actually trying to do: Make it compatible with newer gem versions, not break compatibility with older working ones. Signed-off-by: Frederik Thuysbaert <frederik.thuysbaert@combell.group>
fretb
added a commit
to fretb/rabbitmq_http_api_client
that referenced
this pull request
Nov 5, 2025
In ruby-amqp#67, I proposed to update the dependency constraints to allow the gem to be compatible with newer gem versions. I now see that what I did was wrong, while no code changes were done (meaning that the dependency constraints as they were would still work), I made the gem conflict with working gem versions. I updated the constraints to reflect what I was actually trying to do: Make it compatible with newer gem versions, not break compatibility with older working ones. Signed-off-by: Frederik Thuysbaert <frederik.thuysbaert@combell.group>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates dependencies to their latest version. Verified tests locally, all work.