Fix suspensions in debugger source code (replacement for an old, bad fix) #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valich
reviewed
Jun 17, 2019
ext/debase_internals.c
Outdated
| tp = TRACE_POINT; | ||
| path = rb_tracearg_path(tp); | ||
|
|
||
| if(context->stack_size == context->init_stack_size && context->hit_user_code) { |
Collaborator
There was a problem hiding this comment.
because we might accidentally miss that stackframe (e.g. if an exception occurred)
valich
reviewed
Jun 17, 2019
| static void | ||
| call_at_line(debug_context_t *context, char *file, int line, VALUE context_object) | ||
| { | ||
| context->hit_user_code = 1; |
Collaborator
There was a problem hiding this comment.
how do you use this variable? you only write to it, it seems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to suspend in debugger source code! The most optimal solution is to record a number of service(~debugger) frames and don't handle suspensions in them. After suspension in debugger source code(which was ignored by us) we assume, that for current thread script is over, and we don't need to suspend in it anymore. But we can't disable the whole tracing, because some threads can be active
It should fix ruby-debug-ide tests