Check shell return code in addition to output

[13k]

When the rufo command does not exist, or outputs something with a non-success exit code, the current failure check considers the run as successful, replacing the original buffer with the error message.

By checking the command return code (v:shell_error), it correctly displays the message in the error buffer and keeps the original buffer intact.

[splattael]

@13k Nice, thank you! 👍

I can confirm the behaviour described:

Before

After

@lucerion I suspect that the commit 60241f8 broke it. WDYT?

[splattael]

Forgot to approve 💜

[13k]

@splattael I've updated the PR, it was incorrectly assuming non-zero is an error, but rufo would exit with code 3 for "formatting would change the input". So I'm checking for status !=0 && status != 3.

Something still bugs me, though, that is the "first output line contains the word Error" check. If I'm formatting code that has Error in the first line, it will detect the output as an error, despite the status codes. I think it should only rely on the status codes, not the output.

[13k]

Example:

[lucerion]

@13k it's a hack that can be completely deleted and we can use exit codes only. When I've added it (#5) there was no exit codes in rufo (ruby-formatter/rufo@068bf0b).

[13k]

@lucerion @splattael Updated the PR. It now checks only the exit code.

Thanks for your feedback!

[splattael]

@13k LGTM 👍 but @lucerion should approve as well 💚

[lucerion]

@13k good job! Thank you!