Add support for ldapwhoami (RFC4532)#396
Closed
a7b81a9086 wants to merge 4 commits intoruby-ldap:masterfrom
Closed
Add support for ldapwhoami (RFC4532)#396a7b81a9086 wants to merge 4 commits intoruby-ldap:masterfrom
a7b81a9086 wants to merge 4 commits intoruby-ldap:masterfrom
Conversation
Member
HarlemSquirrel
left a comment
HarlemSquirrel
left a comment
There was a problem hiding this comment.
This looks great! Could you please add a test?
Member
|
@a7b81a9086 Do you have a little time to add a test for this? Thanks! |
1 similar comment
Member
|
@a7b81a9086 Do you have a little time to add a test for this? Thanks! |
Member
|
Added by #425 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this is my first attempt at contributing to an open source project, so if anything is missing feel free to tell me. I am trying to close issue #395 with this pr.
I ran
rake rubotestand it just complained about theNet::LDAPbeing too long, I think the code should be easy enough, as it is just copied from other functions for the most part. Other than that I added one number to the BER-parser that was missing.