Skip to content

Bump warden-webauthn requirement to >= 3.0.0, fix tests #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tcannonfodder merged 1 commit into from
Aug 19, 2023
Merged

Bump warden-webauthn requirement to >= 3.0.0, fix tests #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
PATH
remote: .
specs:
devise-passkeys (0.2.0)
devise-passkeys (0.3.0)
devise (>= 4.7.1)
warden-webauthn (>= 0.2.1)
warden-webauthn (>= 0.3.0)

GEM
remote: https://rubygems.org/
Expand Down Expand Up @@ -104,7 +104,7 @@ GEM
ast (~> 2.4.1)
racc
racc (1.7.1)
rack (2.2.7)
rack (2.2.8)
rack-test (2.1.0)
rack (>= 1.3)
rails-dom-testing (2.1.1)
Expand Down Expand Up @@ -163,7 +163,7 @@ GEM
unicode-display_width (2.4.2)
warden (1.2.9)
rack (>= 2.0.9)
warden-webauthn (0.2.1)
warden-webauthn (0.3.0)
warden
webauthn (>= 3)
webauthn (3.0.0)
Expand Down
2 changes: 1 addition & 1 deletion devise-passkeys.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Gem::Specification.new do |spec|

# Uncomment to register a new dependency of your gem
spec.add_dependency "devise", ">= 4.7.1"
spec.add_dependency "warden-webauthn", ">= 0.2.1"
spec.add_dependency "warden-webauthn", ">= 0.3.0"

# For more information and examples about making a new gem, check out our
# guide at: https://bundler.io/guides/creating_gem.html
Expand Down
12 changes: 6 additions & 6 deletions test/devise/passkeys/controllers/test_passkeys_controller_concern.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def reauthenticate
assert_equal 120_000, response_json["timeout"]
assert_equal ({}), response_json["extensions"]
assert_equal excluded_credentials, response_json["excludeCredentials"]
assert_equal ({ "userVerification" => "required" }), response_json["authenticatorSelection"]
assert_equal ({ "residentKey" => "required", "userVerification" => "required" }), response_json["authenticatorSelection"]
end

test "#create: creates a passkey for the user" do
Expand Down Expand Up @@ -115,7 +115,7 @@ def reauthenticate
assert_equal 120_000, response_json["timeout"]
assert_equal ({}), response_json["extensions"]
assert_equal excluded_credentials, response_json["excludeCredentials"]
assert_equal ({ "userVerification" => "required" }), response_json["authenticatorSelection"]
assert_equal ({ "residentKey" => "required", "userVerification" => "required" }), response_json["authenticatorSelection"]

raw_credential = client.create(challenge: response_json["challenge"], user_verified: true)

Expand Down Expand Up @@ -189,7 +189,7 @@ def reauthenticate
assert_equal 120_000, response_json["timeout"]
assert_equal ({}), response_json["extensions"]
assert_equal excluded_credentials, response_json["excludeCredentials"]
assert_equal ({ "userVerification" => "required" }), response_json["authenticatorSelection"]
assert_equal ({ "residentKey" => "required", "userVerification" => "required" }), response_json["authenticatorSelection"]

raw_credential = client.create(challenge: response_json["challenge"], user_verified: false)

Expand Down Expand Up @@ -237,7 +237,7 @@ def reauthenticate
assert_equal 120_000, response_json["timeout"]
assert_equal ({}), response_json["extensions"]
assert_equal excluded_credentials, response_json["excludeCredentials"]
assert_equal ({ "userVerification" => "required" }), response_json["authenticatorSelection"]
assert_equal ({ "residentKey" => "required", "userVerification" => "required" }), response_json["authenticatorSelection"]

raw_credential = client.create(challenge: "blah", user_verified: true)

Expand Down Expand Up @@ -360,7 +360,7 @@ def reauthenticate
assert_equal 120_000, response_json["timeout"]
assert_equal ({}), response_json["extensions"]
assert_equal excluded_credentials, response_json["excludeCredentials"]
assert_equal ({ "userVerification" => "required" }), response_json["authenticatorSelection"]
assert_equal ({ "residentKey" => "required", "userVerification" => "required" }), response_json["authenticatorSelection"]

raw_credential = client.create(challenge: response_json["challenge"], user_verified: true)

Expand Down Expand Up @@ -405,7 +405,7 @@ def reauthenticate
assert_equal 120_000, response_json["timeout"]
assert_equal ({}), response_json["extensions"]
assert_equal excluded_credentials, response_json["excludeCredentials"]
assert_equal ({ "userVerification" => "required" }), response_json["authenticatorSelection"]
assert_equal ({ "residentKey" => "required", "userVerification" => "required" }), response_json["authenticatorSelection"]

raw_credential = client.create(challenge: response_json["challenge"], user_verified: true)

Expand Down
2 changes: 1 addition & 1 deletion test/devise/passkeys/controllers/test_registrations_controller_concern.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def resource_name
assert_equal 120_000, response_json["timeout"]
assert_equal ({}), response_json["extensions"]
assert_empty response_json["excludeCredentials"]
assert_equal ({ "userVerification" => "required" }), response_json["authenticatorSelection"]
assert_equal ({ "residentKey" => "required", "userVerification" => "required" }), response_json["authenticatorSelection"]
end

test "#create: success" do
Expand Down