Rename Devise::Passkeys::Controllers::Concerns::PasskeyReauthentication => Devise::Passkeys::Controllers::Concerns::Reauthentication
#7
Conversation
Find and replaced PasskeyReauthentication with Reauthentication, and test_passkey_reauthentication with test_reauthetntication. As well as renamed files.
tcannonfodder
left a comment
tcannonfodder
left a comment
There was a problem hiding this comment.
It's almost there; but it looks like we've got a case of find & replace gone amok!
The only things that need to be renamed are:
The PasskeyReauthentication concern
Devise::Passkeys::Controllers::Concerns::PasskeyReauthentication => Devise::Passkeys::Controllers::Concerns::Reauthentication
The test class:
Devise::Passkeys::Controllers::Concerns::TestPasskeyReauthentication => Devise::Passkeys::Controllers::Concerns::TestReauthentication
- The filenames for each
- The requiring of
"controllers/concerns/passkey_reauthentication"inlib/devise/passkeys/controllers.rb
The other changes here (making methods start with an uppercase, changing the symbol names, changing the name of the strategy) will need to be rolled back.
Let me know if you have any questions or need anything clarified!
lib/devise/passkeys/controllers/reauthentication_controller_concern.rb
Outdated
Show resolved
Hide resolved
lib/devise/passkeys/controllers/reauthentication_controller_concern.rb
Outdated
Show resolved
Hide resolved
lib/devise/passkeys/controllers/concerns/reauthentication_challenge.rb
Outdated
Show resolved
Hide resolved
lib/devise/passkeys/controllers/concerns/reauthentication_challenge.rb
Outdated
Show resolved
Hide resolved
lib/devise/passkeys/controllers/reauthentication_controller_concern.rb
Outdated
Show resolved
Hide resolved
test/devise/passkeys/controllers/concerns/test_reauthentication.rb
Outdated
Show resolved
Hide resolved
Reran find and replace for PasskeyReauthentication to Reauthentication Updated file names
tcannonfodder
left a comment
tcannonfodder
left a comment
There was a problem hiding this comment.
There was one goof up I made in my feedback. I also need to run this on CircleCI to confirm it passes
* This actually needs to remain as `Devise::Strategies::PasskeyReauthentication` because it's the class that defines the devise strategy. * Similar to how we kept the key as :passkey_reauthentication, the class needs to stay the same (especially because it's convention for the key & class to mirror each other).
tcannonfodder
changed the title
Devise::Passkeys::Controllers::Concerns::PasskeyReauthentication => Devise::Passkeys::Controllers::Concerns::Reauthentication
|
@tcannonfodder , @johalloran01 : how pick are you about adding these changes to CHANGELOG.md? |
|
I’m not sure I follow? I did add them in a later commit, post-merging: de50113 😄😅 |
|
TY! Sorry about that! |
|
No worries! Just wanted to make sure I didn’t miss anything 😄 |
3 participants
Find and replaced PasskeyReauthentication with Reauthentication, and test_passkey_reauthentication with test_reauthetntication. As well as renamed files.