Avoid unnecessary string duplication in .urlsafe_decode64 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe some long time ago this used minitest? That's not the case anymore.
String#ljust returns a new string, so whenever we need to add padding, we can replace "-/" in place with String#tr! and avoid creating yet another copy of the string.
Member
|
Thanks.
Also thanks to update this. I forgot to change it. |
Contributor
Author
You're welcome! Thanks for the quick feedback. 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String#ljustreturns a new string, so whenever we need to add padding, we can replace "-/" in place withString#tr!and avoid creating yet another copy of the string. My benchmarks point to a 1.08-1.18x speedup.I took the time to replace minitest with test-unit as it's the testing framework being used. Probably just an old unnoticed detail.