Fix unescapeHTML #48
Merged
Fix unescapeHTML #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This looks like a reasonable problem to solve. Do you mind adding an initial commit with failing test cases? |
Contributor
Author
|
Done. |
Contributor
Author
|
It appears the added test cases make JRuby fail as well. It is now fixed. |
Member
|
Looks good to me, but I think @nobu is the CGI maintainer. |
jeremyevans
reviewed
Nov 28, 2023
Contributor
jeremyevans
left a comment
jeremyevans
left a comment
There was a problem hiding this comment.
Also looks fine to me.
nobu
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of
optimized_unescape_htmlis inconsistent with Ruby's implementation ofunescapeHTMLfor some edge cases, such as&a>, where Ruby's implementation gives&a>butoptimized_unescape_htmlleaves it unchanged because the second&is skipped afterais parsed.