Add invalid: :replace for CSV.open
#130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Jun 3, 2020
lib/csv/writer.rb
Outdated
| field = String(field) # Stringify fields | ||
| # represent empty fields as empty quoted fields | ||
| if (@quote_empty and field.empty?) or @quotable_pattern.match?(field) | ||
| if (@quote_empty and field.empty?) or @quotable_pattern.match?(field.scrub) |
Member
There was a problem hiding this comment.
I don't think that this is a good approach.
If we have \uFFFD in @quotable_pattern, it matches all invalid characters.
We need to process this case carefully something like:
Suggested change
| if (@quote_empty and field.empty?) or @quotable_pattern.match?(field.scrub) | |
| if (@quote_empty and field.empty?) or (filed.valid_encoding? and @quotable_pattern.match?(field) |
Could you create a separated pull request for this case and then we can back to this pull request?
Contributor
Author
There was a problem hiding this comment.
Thanks for your suggestion. I think that is definitely a safe approach and suitable. I've opened #131.
Contributor
Author
There was a problem hiding this comment.
I rebased this PR with the latest mater branch.
koic
force-pushed
the
add_invalid_replace_option_for_csv_open
branch
from
76bdf53 to
59b4305
Compare
This PR adds `invalid: :replace` for `CSV.open`. It is a PR similar to ruby#129. And this PR uses `String#scrub` to prevent the following `ArgumentError`. ```ruby /[,"]/.match?("\x82\xA0") #=> ArgumentError (invalid byte sequence in UTF-8) /[,"]/.match?("\x82\xA0".scrub) #=> false ```
koic
force-pushed
the
add_invalid_replace_option_for_csv_open
branch
from
59b4305 to
d1f9bc0
Compare
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
invalid: :replaceforCSV.open. It is a PR similar to #129.