Skip to content

fix: Date#hash for large years #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nobu merged 1 commit into from
Jun 15, 2025
Merged

fix: Date#hash for large years #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions ext/date/date_core.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6936,13 +6936,24 @@ d_lite_eql_p(VALUE self, VALUE other)
static VALUE
d_lite_hash(VALUE self)
{
st_index_t v, h[4];
st_index_t v, h[5];
VALUE nth;

get_d1(self);
h[0] = m_nth(dat);
h[1] = m_jd(dat);
h[2] = m_df(dat);
h[3] = m_sf(dat);
nth = m_nth(dat);

if (FIXNUM_P(nth)) {
h[0] = 0;
h[1] = (st_index_t)nth;
} else {
h[0] = 1;
h[1] = (st_index_t)FIX2LONG(rb_hash(nth));
}

h[2] = m_jd(dat);
h[3] = m_df(dat);
h[4] = m_sf(dat);

v = rb_memhash(h, sizeof(h));
return ST2FIX(v);
}
Expand Down
4 changes: 4 additions & 0 deletions test/date/test_date.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,10 @@ def test_hash
assert_equal(9, h[Date.new(1999,5,25)])
assert_equal(9, h[DateTime.new(1999,5,25)])

h = {}
h[Date.new(3171505571716611468830131104691,2,19)] = 0
assert_equal(true, h.key?(Date.new(3171505571716611468830131104691,2,19)))

h = {}
h[DateTime.new(1999,5,23)] = 0
h[DateTime.new(1999,5,24)] = 1
Expand Down