Skip to content

[DOC] Enhanced RDoc #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BurdetteLamar merged 9 commits into from
Jul 4, 2022
Merged

[DOC] Enhanced RDoc #56

BurdetteLamar merged 9 commits into from
Jul 4, 2022

Conversation

@BurdetteLamar
Copy link
Member

@BurdetteLamar BurdetteLamar commented Jul 3, 2022

Treats methods:

  • ::valid_jd?
  • ::valid_civil?
  • ::valid_ordinal?
  • ::valid_commercial?
  • ::julian_leap?
  • ::gregorian_leap?
  • ::jd
  • ::ordinal
  • ::new
    Adds section "Argument +start+".

peterzhu2118
peterzhu2118 reviewed Jul 3, 2022
View reviewed changes
peterzhu2118
peterzhu2118 reviewed Jul 4, 2022
View reviewed changes
@BurdetteLamar @peterzhu2118
Update ext/date/date_core.c
8eb1c78 
Co-authored-by: Peter Zhu <peter@peterzhu.ca>
peterzhu2118
peterzhu2118 approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@peterzhu2118 peterzhu2118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@BurdetteLamar BurdetteLamar merged commit 6af49d4 into ruby:master Jul 4, 2022
@nobu
Copy link
Member

nobu commented Jul 4, 2022

Please more meaningful commit logs per commits, or squash.

@BurdetteLamar
Copy link
Member Author

BurdetteLamar commented Jul 4, 2022

Please more meaningful commit logs per commits, or squash.

I didn't squash! :(
Sometimes that's the default offered; sometimes it isn't. I'll be watchful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterzhu2118 peterzhu2118 peterzhu2118 approved these changes

Assignees

No one assigned

Labels

documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BurdetteLamar @nobu @peterzhu2118