Skip to content

[DOC] Enhanced intro for Date #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BurdetteLamar merged 8 commits into from
Aug 15, 2022
Merged

[DOC] Enhanced intro for Date #72

BurdetteLamar merged 8 commits into from
Aug 15, 2022

Conversation

@BurdetteLamar
Copy link
Member

@BurdetteLamar BurdetteLamar commented Aug 7, 2022

No description provided.

peterzhu2118
peterzhu2118 reviewed Aug 8, 2022
View reviewed changes
peterzhu2118
peterzhu2118 reviewed Aug 8, 2022
View reviewed changes
peterzhu2118
peterzhu2118 reviewed Aug 8, 2022
View reviewed changes
Copy link
Member

@peterzhu2118 peterzhu2118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@BurdetteLamar
Copy link
Member Author

BurdetteLamar commented Aug 8, 2022

Let me clarify your question, do you mean moving information about HTTP format, RFC 3339, RFC 2822, JIS X 0301 into the strftime page?

Yes, entire section "Standard Format Strings," any necessary changes having been made; then link as needed from elsewhere.

@peterzhu2118
Copy link
Member

peterzhu2118 commented Aug 8, 2022

Yeah I think we can move information about these formats into that document.

@BurdetteLamar
Copy link
Member Author

BurdetteLamar commented Aug 13, 2022

@peterzhu2118, I have linked to "Formats for Dates and Times" from the specialized format methods.

peterzhu2118
peterzhu2118 reviewed Aug 13, 2022
View reviewed changes
@BurdetteLamar @peterzhu2118
Update ext/date/date_core.c
1cfb1ff 
Co-authored-by: Peter Zhu <peter@peterzhu.ca>
peterzhu2118
peterzhu2118 reviewed Aug 14, 2022
View reviewed changes
peterzhu2118
peterzhu2118 approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@peterzhu2118 peterzhu2118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BurdetteLamar BurdetteLamar merged commit 59a6673 into ruby:master Aug 15, 2022
matzbot pushed a commit to ruby/ruby that referenced this pull request Aug 15, 2022
@BurdetteLamar @matzbot
[ruby/date] [DOC] Enhanced intro for Date (ruby/date#72)
8d40ede 
ruby/date@59a6673221
maximecb added a commit to Shopify/ruby that referenced this pull request Aug 16, 2022
@maximecb @jeremyevans
@nobu @BurdetteLamar @mrkn @matzbot @mame @kyanagi @tompng @S-H-GAMELINKS @deivid-rodriguez @peterzhu2118 @k0kubun
Merge commits from ruby/master into yjit_backend_ir (#406)
fcda66f 
* Only allow procs created by Symbol#to_proc to call public methods

Fixes [Bug #18826]

Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>

* Revert "Add {Method,UnboundMethod}#{public?,private?,protected?}"

This reverts commit 2727815 and
58dc8bf.

Visibility is an attribute of the method entry in a class, not an
attribute of the Method object.

Fixes [#18729]
Fixes [#18751]
Fixes [#18435]

* [ruby/rdoc] Treat text markup (italic, bold, monofont) as blocks (ruby/rdoc#911)

ruby/rdoc@dc88f1b425

* Add `--enable-devel` configure option

Since `RUBY_DEVEL` in cppflags has no effect in the configure script
and makefiles.

* Fix paths of exts.mk to clean

exts.mk files are one level under the top of extension directories.

* The "gems" build directory was rename as ".bundle"

* Fix race conditions when cleaning extensions

Clean built directories by `make distclean`, and then clean leftover
makefiles for skipped extensions.

* Fix Array#[] with ArithmeticSequence with negative steps (ruby#5739)

* Fix Array#[] with ArithmeticSequence with negative steps

Previously, Array#[] when called with an ArithmeticSequence
with a negative step did not handle all cases correctly,
especially cases involving infinite ranges, inverted ranges,
and/or exclusive ends.

Fixes [Bug #18247]

* Add Array#slice tests for ArithmeticSequence with negative step to test_array

Add tests of rb_arithmetic_sequence_beg_len_step C-API function.

* Fix ext/-test-/arith_seq/beg_len_step/depend

* Rename local variables

* Fix a variable name

Co-authored-by: Kenta Murata <3959+mrkn@users.noreply.github.com>

* [ruby/rdoc] [DOC] Make example formats explicit and consistent (ruby/rdoc#913)

ruby/rdoc@7e6ef6c855

* Fix inspect for unicode codepoint 0x85

This is an inelegant hack, by manually checking for this specific
code point in rb_str_inspect.  Some testing indicates that this is
the only code point affected.

It's possible a better fix would be inside of lower-level encoding
code, such that rb_enc_isprint would return false and not true for
codepoint 0x85.

Fixes [Bug #16842]

* * 2022-08-12 [ci skip]

* [ruby/rdoc] Improvements to Text Markup examples (ruby/rdoc#915)

ruby/rdoc@d00ddfe57c

* [ruby/rdoc] Mods to section Text Markup (ruby/rdoc#916)

ruby/rdoc@5506d4d67e

* [ruby/error_highlight] Add a note about the current limitation of ErrorHighlight.spot

ruby/error_highlight@489ce80a62

* All extensions in bundled gems are built by build-ext now

`RbInstall::GemInstaller#build_extensions` has nothing to do.

* No bundled gems to be installed from gem now

* [DOC] Use `true`/`false` for `@retval`s which are `bool`

* Add missing `rb_enc_iscntrl`

* Stop defining `RUBY_ABI_VERSION` if released versions

As commented in include/ruby/internal/abi.h, since teeny versions of
Ruby should guarantee ABI compatibility, `RUBY_ABI_VERSION` has no role
in released versions of Ruby.

* Add Numeric#ceildiv and Integer#ceildiv

* Remove Numeric#ceildiv

* Improve performance of Integer#ceildiv

This patch is suggested by nobu.

Benchmark result:

```
require 'benchmark'

n = 10 ** 7

Benchmark.bm do |x|
  x.report("Fixnum/Fixnum") { a, b = 5, 2; n.times { a.ceildiv(b) } }
  x.report("Bignum/Bignum") { a, b = 10**100, 10**99 - 1; n.times { a.ceildiv(b) } }
  x.report("Bignum/Fixnum") { a, b = 10**100, 3; n.times { a.ceildiv(b) } }
end
```

Original:

```
       user     system      total        real
Fixnum/Fixnum  3.340009   0.043029   3.383038 (  3.384022)
Bignum/Bignum  8.229500   0.118543   8.348043 (  8.349574)
Bignum/Fixnum  8.328971   0.097842   8.426813 (  8.426952)
```

Improved:

```
       user     system      total        real
Fixnum/Fixnum  0.699140   0.000961   0.700101 (  0.700199)
Bignum/Bignum  5.076165   0.083160   5.159325 (  5.159360)
Bignum/Fixnum  5.548684   0.115372   5.664056 (  5.666735)
```

* [Bug #18962] Do not read again once reached EOF

`Ripper::Lexer#parse` re-parses the source code with syntax errors
when `raise_errors: false`.

Co-Authored-By: tompng <tomoyapenguin@gmail.com>

* Short-circuit `Process._fork`

* Introduce with_warn_vsprintf macro

* Bundle unreleased debug

* Preserve each column positions in gems/bundled_gems

* Adjust columns in gems/bundled_gems [ci skip]

* [ruby/rdoc] [DOC] Enhances text about escapes (ruby/rdoc#917)

ruby/rdoc@c40bac829c

* * 2022-08-13 [ci skip]

* Add a NEWS entry about Integer#ceildiv [ci skip]

* [DOC] Add the link to [Feature #18809]

* Silent configure does not output cached configurations

* * 2022-08-14 [ci skip]

* Update dependencies

* [ruby/rinda] Handle situations where IPv4 multicast is not available

Fixes [Bug ruby#13864]

ruby/rinda@3cd620f38c

* * 2022-08-15 [ci skip]

* [rubygems/rubygems] Fix Ruby platform incorrectly removed on `bundle update`

ruby/rubygems@0d321c9e3a

* [ruby/date] [DOC] Enhanced intro for Date (ruby/date#72)

ruby/date@59a6673221

* Add test for GC thrashing of young object creation

This test will prevent performance regressions like [Bug #18929].

* Simplify around `USE_YJIT` macro (ruby#6240)

* Simplify around `USE_YJIT` macro

- Use `USE_YJIT` macro only instead of `YJIT_BUILD`.
- An intermediate macro `YJIT_SUPPORTED_P` is no longer used.

* Bail out if YJIT is enabled on unsupported platforms

* * 2022-08-16 [ci skip]

* [ruby/rdoc] [DOC] Remove duplicated line in RDoc::MarkupReference

ruby/rdoc@488f89aee4

* Allow aarch64 to build YJIT

Co-authored-by: Jeremy Evans <code@jeremyevans.net>
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
Co-authored-by: Burdette Lamar <BurdetteLamar@Yahoo.com>
Co-authored-by: Kenta Murata <3959+mrkn@users.noreply.github.com>
Co-authored-by: git <svn-admin@ruby-lang.org>
Co-authored-by: Yusuke Endoh <mame@ruby-lang.org>
Co-authored-by: Kouhei Yanagita <yanagi@shakenbu.org>
Co-authored-by: tompng <tomoyapenguin@gmail.com>
Co-authored-by: S-H-GAMELINKS <gamelinks007@gmail.com>
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Co-authored-by: Peter Zhu <peter@peterzhu.ca>
Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterzhu2118 peterzhu2118 peterzhu2118 approved these changes

Assignees

No one assigned

Labels

documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BurdetteLamar @peterzhu2118