Implement Date#deconstruct_keys and DateTime#deconstruct_keys #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hmm, interesting, it seems to only be compilable under 3.2 🤔 |
Contributor
|
Sorry that I haven't had a chance to review this yet, I'm currently at RubyConfTH and haven't had a lot of free time. I should be able to review next week. From a brief review of the build error, you can probably switch from |
zverok
force-pushed
the
deconstruct_keys
branch
from
69301b5 to
c4708bb
Compare
Contributor
Author
|
@jeremyevans Yeah, makes sense. All green now. |
jeremyevans
requested changes
Dec 11, 2022
Contributor
jeremyevans
left a comment
jeremyevans
left a comment
There was a problem hiding this comment.
Looks good, thanks for working on this. I have some minor requests for changes, then this can be merged.
jeremyevans
approved these changes
Dec 13, 2022
zverok
force-pushed
the
deconstruct_keys
branch
from
ef6f6dc to
6bb6d3a
Compare
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as ruby/ruby#6594, but for
Date&DateTime.