Skip to content

Revert "Allow use of DelegateClass in ractors" #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nobu merged 1 commit into from
Dec 18, 2025
Merged

Revert "Allow use of DelegateClass in ractors" #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions lib/delegate.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,16 +345,10 @@ def __setobj__(obj)
end

def Delegator.delegating_block(mid) # :nodoc:
prok = lambda do |*args, &block|
lambda do |*args, &block|
target = self.__getobj__
target.__send__(mid, *args, &block)
end
prok.ruby2_keywords
if defined?(Ractor.shareable_proc)
Ractor.shareable_proc(&prok)
else
prok
end
end.ruby2_keywords
end

#
Expand Down
16 changes: 0 additions & 16 deletions test/test_delegate.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,20 +390,4 @@ def test(a, k:) [a, k]; end
a = DelegateClass(k).new(k.new)
assert_equal([1, 0], a.test(1, k: 0))
end

def test_delegate_class_can_be_used_in_ractors
omit "no Ractor#value" unless defined?(Ractor) && Ractor.method_defined?(:value)
require_path = File.expand_path(File.join(__dir__, "..", "lib", "delegate.rb"))
raise "file doesn't exist: #{require_path}" unless File.exist?(require_path)
assert_ractor <<-RUBY
require "#{require_path}"
class MyClass < DelegateClass(Array);end
values = 2.times.map do
Ractor.new do
MyClass.new([1,2,3]).at(0)
end
end.map(&:value)
assert_equal [1,1], values
RUBY
end
end