Skip to content

Conversation

@ahorek
Copy link

@ahorek ahorek commented Sep 30, 2021

digest/digest.jar should be included

@ahorek ahorek mentioned this pull request Sep 30, 2021
@knu
Copy link
Member

knu commented Sep 30, 2021

Thanks. It's sad the integration test passed because the digest library would be still available even if the jar were missing. 🥺

Copy link
Member

@knu knu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits into one.

@ahorek
Copy link
Author

ahorek commented Sep 30, 2021

It's sad the integration test passed because the digest library would be still available even if the jar were missing. 🥺

the library is available because it wasn't removed yet https://github.com/jruby/jruby/pull/6719/files

Copy link
Member

@knu knu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@knu knu merged commit 7941af8 into ruby:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants