Refactor the logic of require 'erb/escape' #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
May 13, 2025
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
May 13, 2025
k0kubun
added a commit
that referenced
this pull request
May 13, 2025
This reverts commit 1c9200a. Now that we've bumped BASERUBY, we shouldn't need to rescue the LoadError.
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
May 13, 2025
(ruby/erb#61)" This reverts commit ruby/erb@1c9200aab071. Now that we've bumped BASERUBY, we shouldn't need to rescue the LoadError. ruby/erb@846b20fe0e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$LOAD_PATH.resolve_feature_pathdoes not raise on Ruby 3.1+. Now that we require Ruby 3.2 #60, we should be able to skip rescuingLoadError.