Fix type error on empty backtrace locations #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test fails with the following error: Error: test_simulate_funcallv_from_embedded_ruby(ErrorHighlightTest): TypeError: wrong argument type nil (expected method)
When we have no backtrace locations, we can't have the highlight, so just return the message.
Didthat
approved these changes
Dec 31, 2021
Contributor
Author
Spam? |
Member
Yes. We couldn't delete that. GitHub must fix this behavior or prevent to post as spam. |
Member
|
@cboos Thank you for your pull request! It looks reasonable. I'll merge it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
ErrorHighlight::CoreExt#to_s, thebacktrace_locationsis checked before use, but that check doesn't cover all the cases.If you happen to call directly
rb_funcallvfrom a C program in an embedded Ruby scenario and an exception is raised, then thebacktrace_locationswill be an emptyArray, notnil. In such an application, my error reporting code callsto_son therb_errinfo()value, and with Ruby 3.1 this results in aTypeError: wrong argument type nil (expected method)as theErrorHighlight::CoreExt#to_smethod uses alocthat is nownil.I believe the correct thing to do here is to return
msgas well.