Skip to content

Conversation

@m-nakamura145
Copy link
Contributor

Previously, Ruby versions in ruby.yml were specified using an array. However, this PR has been changed to use the ruby/actions workflow for version.

@hsbt
Copy link
Member

hsbt commented Jan 7, 2024

@m-nakamura145 Thanks. Can you use min version to 3.0? HEAD version is already removed Ruby 3.0 from supported versions.

@m-nakamura145
Copy link
Contributor Author

@hsbt oh, sorry. I'd like to exclude Ruby 3.0 because error_highlight supports Ruby 3.1 and above.
I thought I could exclude 3.0 by setting 3.1 in min_version input in ruby/actions. However, 3.0 cannot be excluded because cruby.json returns the following array. How should I set this up?

❯ curl https://cache.ruby-lang.org/pub/misc/ci_versions/cruby.json
["3.0","3.1","3.2","3.3","head"]

I think we can achieve this by improving this step.

@hsbt
Copy link
Member

hsbt commented Jan 7, 2024

Ah, I see. It seems bug of ruby/actions. I will fix it next week.

@m-nakamura145
Copy link
Contributor Author

@hsbt Thanks for your help! I created ruby/actions#56 👍

@hsbt hsbt reopened this Jan 10, 2024
@hsbt
Copy link
Member

hsbt commented Jan 10, 2024

@m-nakamura145 I appreciate your work. This change is working correctly.

@hsbt hsbt merged commit 80ede6b into ruby:master Jan 10, 2024
@m-nakamura145 m-nakamura145 deleted the use-ruby/actions-for-ruby-versions branch January 10, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants