Rename the ErrorHighlight::DefaultFormatter setting to max_snippet_width for clarity
#52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karreiro
changed the title
ErrorHighlight::DefaultFormatter setting to max_snippet_width for clarityErrorHighlight::DefaultFormatter setting to max_snippet_width for clarity
…_width` for clarity
karreiro
force-pushed
the
default-formatter-setting
branch
from
fc54e82 to
a442240
Compare
Merged
mame
approved these changes
Oct 24, 2024
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the #51 (comment) thread, this PR updates the global setting for snippet truncation. We're moving from
ErrorHighlight::DefaultFormatter.snippet_max_widthtoErrorHighlight::DefaultFormatter.max_snippet_width.