Skip to content

Support cases where there are multiple missing / wrong kwargs #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mame merged 1 commit into from
Oct 30, 2025
Merged

Support cases where there are multiple missing / wrong kwargs #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/error_highlight/core_ext.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
module ErrorHighlight
module CoreExt
private def generate_snippet
if ArgumentError === self && message =~ /\A(?:wrong number of arguments|missing keyword|unknown keyword|no keywords accepted)\b/
if ArgumentError === self && message =~ /\A(?:wrong number of arguments|missing keyword[s]?|unknown keyword[s]?|no keywords accepted)\b/
locs = self.backtrace_locations
return "" if locs.size < 2
callee_loc, caller_loc = locs
Expand Down
44 changes: 43 additions & 1 deletion test/test_error_highlight.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def preprocess(msg)
def assert_error_message(klass, expected_msg, &blk)
omit unless klass < ErrorHighlight::CoreExt
err = assert_raise(klass, &blk)
unless klass == ArgumentError && err.message =~ /\A(?:wrong number of arguments|missing keyword|unknown keyword|no keywords accepted)\b/
unless klass == ArgumentError && err.message =~ /\A(?:wrong number of arguments|missing keyword[s]?|unknown keyword[s]?|no keywords accepted)\b/
spot = ErrorHighlight.spot(err)
if spot
assert_kind_of(Integer, spot[:first_lineno])
Expand Down Expand Up @@ -1502,6 +1502,27 @@ def test_missing_keyword
end
end

def test_missing_keywords # multiple missing keywords
lineno = __LINE__
assert_error_message(ArgumentError, <<~END) do
missing keywords: :kw2, :kw3 (ArgumentError)

caller: #{ __FILE__ }:#{ lineno + 16 }
| keyword_test(kw1: 1)
^^^^^^^^^^^^
callee: #{ __FILE__ }:#{ KEYWORD_TEST_LINENO }
#{
MethodDefLocationSupported ?
"| def keyword_test(kw1:, kw2:, kw3:)
^^^^^^^^^^^^" :
"(cannot highlight method definition; try Ruby 3.5 or later)"
}
END

keyword_test(kw1: 1)
end
end

def test_unknown_keyword
lineno = __LINE__
assert_error_message(ArgumentError, <<~END) do
Expand All @@ -1523,6 +1544,27 @@ def test_unknown_keyword
end
end

def test_unknown_keywords
lineno = __LINE__
assert_error_message(ArgumentError, <<~END) do
unknown keywords: :kw4, :kw5 (ArgumentError)

caller: #{ __FILE__ }:#{ lineno + 16 }
| keyword_test(kw1: 1, kw2: 2, kw3: 3, kw4: 4, kw5: 5)
^^^^^^^^^^^^
callee: #{ __FILE__ }:#{ KEYWORD_TEST_LINENO }
#{
MethodDefLocationSupported ?
"| def keyword_test(kw1:, kw2:, kw3:)
^^^^^^^^^^^^" :
"(cannot highlight method definition; try Ruby 3.5 or later)"
}
END

keyword_test(kw1: 1, kw2: 2, kw3: 3, kw4: 4, kw5: 5)
end
end

WRONG_NUBMER_OF_ARGUMENTS_TEST2_LINENO = __LINE__ + 1
def wrong_number_of_arguments_test2(
long_argument_name_x,
Expand Down