Fix test_dlopen_linker_script_input_linux being omitted on Fedora 40 aarch64 #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Easy test fix, merged! |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Dec 10, 2024
omitted on Fedora 40 aarch64 (ruby/fiddle#161) I found working on Fedora 40 on aarch64 that `test_dlopen_linker_script_input_linux` was omitted due to not finding libncurses.so, since it is in /usr/lib64. This PR makes the glob a little more portable. ruby/fiddle@444774c0c4
nobu
reviewed
Dec 10, 2024
| def test_dlopen_linker_script_input_linux | ||
| omit("This is only for Linux") unless RUBY_PLATFORM.match?("linux") | ||
| if Dir.glob("/usr/lib/*/libncurses.so").empty? | ||
| if Dir.glob("/usr/lib{64}/**/libncurses.so").empty? |
Member
There was a problem hiding this comment.
What did you intend by {64}?
As it doesn't contain any ,, it matches the /usr/lib64 directory only.
kou
pushed a commit
that referenced
this pull request
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found working on Fedora 40 on aarch64 that
test_dlopen_linker_script_input_linuxwas omitted due to not finding libncurses.so, since it is in /usr/lib64. This PR makes the glob a little more portable.