Skip to content

Fix Fiddle.last_error on FFI backend and improve test to work for all #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kou merged 1 commit into from
Feb 2, 2025
Merged

Fix Fiddle.last_error on FFI backend and improve test to work for all #173

kou merged 1 commit into from
Feb 2, 2025
+28 −14

Conversation

@eregon
Copy link
Member

@eregon eregon commented Jan 31, 2025

No description provided.

@eregon eregon requested a review from kou January 31, 2025 21:56
@eregon eregon mentioned this pull request Jan 31, 2025
Merged
eregon
eregon commented Jan 31, 2025
View reviewed changes
@eregon
Copy link
Member Author

eregon commented Jan 31, 2025

Mmh, JRuby on Windows seems to have a bug here, cc @headius:
https://github.com/ruby/fiddle/actions/runs/13081426763/job/36505655327?pr=173#step:7:31

assert_equal RbConfig::LIMITS["LONG_MAX"], strtol.call((2**128).to_s, nil, 10)
<9223372036854775807> expected but was
<2147483647>

LONG_MAX on Windows is 2147483647 (LLP64), but RbConfig::LIMITS["LONG_MAX"] on JRuby on Windows reports 9223372036854775807 (incorrect).
(I made sure the value before expected is the LHS, so it's not the other way around)

@kou
Copy link
Member

kou commented Jan 31, 2025

jruby/jruby#8357 may be related for the JRuby behavior.

@eregon
Copy link
Member Author

eregon commented Jan 31, 2025 •
edited
Loading

Worked around the JRuby on Windows failure by not asserting the result of strol(), it's not really important, we are testing errno.

@eregon
Copy link
Member Author

eregon commented Jan 31, 2025 •
edited
Loading

There is another error for JRuby on Windows, I'll skip that test for it then:
https://github.com/ruby/fiddle/actions/runs/13082143360/job/36507738494?pr=173

@eregon eregon force-pushed the fix-last_error branch 3 times, most recently from 693c156 to 29e3261 Compare January 31, 2025 22:59
@eregon
Copy link
Member Author

eregon commented Jan 31, 2025 •
edited
Loading

CI is green now and this PR is ready

kou
kou reviewed Feb 1, 2025
View reviewed changes
@eregon eregon requested a review from kou February 2, 2025 17:02
@kou kou merged commit ef2382a into ruby:master Feb 2, 2025
66 checks passed
@kou
Copy link
Member

kou commented Feb 2, 2025

Thanks.

matzbot pushed a commit to ruby/ruby that referenced this pull request Feb 3, 2025
@eregon @hsbt
[ruby/fiddle] Fix Fiddle.last_error on FFI backend and improve test
15e6f13 
to work for all
(ruby/fiddle#173)

ruby/fiddle@ef2382a7ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou Awaiting requested review from kou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eregon @kou