Make array access override compatible with base class #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was split from #14 as requested by @nobu .
CStructEntitydefines array subscript methods ([]/[]=), which is fine except that they overrideFiddle::Pointer#[]andFiddle::Pointer#[]=and do not handle the 3rd argument that the base class allows for. The methods fromFiddle::Pointerprovide for direct manipulation of the underlying memory, but this ability is lost inCStructEntitybecause the superclass methods are not available in the subclass (ignoring ugly hacks likeFiddle::Pointer.method(:[]).unbind.bind(struct).call). This pull request modifies the overridden methods to check for an additional argument which would be understood bysuper. If the extra argument is provided,superis called so that the underlying memory can be accessed / assigned directly.Here is an example: