Add GH Actions #35
Merged
Add GH Actions #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
It seems that "windows mswin" is failed: https://github.com/MSP-Greg/fiddle/runs/711008486?check_suite_focus=true What should we do for this? |
Member
|
Ah, you want to show "windows mswin" is failed. |
Member
|
Should we merge this and fix the problem? |
Contributor
Author
Yes. Sorry, I should have opened an issue for that, rather than noting it in this PR. Also, the issue with ext/fiddle/extlibs using 3.2.1, both here and in ruby/ruby.
Re merging, whatever you prefer. The CI runs quickly, so I used a 'complete' matrix of jobs. As to fixing the problem, my c knowledge is limited, so I wouldn't be much help. Thanks. |
Member
|
OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the ruby head mswin build broke from fiddle. ruby/ruby appears to download libffi 3.2.1 for the mswin build, but 3.3 is vendored here.
I started here and created a GitHub Actions workflow, covering Ruby 2.3 thru master/head for Ubuntu, macOS, and Windows. All are passing except Windows mswin. I did add a compile step just to see what was happening.
This may not run, as often the first PR with a GHA workflow doesn't. A link to a run in my fork is:
https://github.com/MSP-Greg/fiddle/actions/runs/116195157