Skip to content

Conversation

@nobu
Copy link
Member

@nobu nobu commented Jul 10, 2021

Drop supports for old versions, keeping 2.5 as CI supports it for now.

Drop supports for old versions, keeping 2.5 as CI supports it for
now.
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kou kou merged commit 90634e7 into ruby:master Jul 11, 2021
@nobu nobu deleted the required_ruby_version branch July 13, 2021 09:42
matzbot pushed a commit to ruby/ruby that referenced this pull request Jul 13, 2021
Drop supports for old versions, keeping 2.5 as CI supports it for
now.

ruby/fiddle@90634e7c55
kou pushed a commit that referenced this pull request Dec 20, 2022
String#unpack1 is available since Ruby 2.4, and support for older than
Ruby 2.5 was dropped by #85.
Also simplified a common return statement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants