Make def_{instance,single}_delegators skip :__send__ and :__id__ #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, __send__ and __id__ were skipped if provided as strings, but not skipped if provided as symbols. Fixes Ruby Bug 8855.
znz
reviewed
Aug 21, 2019
lib/forwardable.rb
Outdated
| methods.delete("__id__") | ||
| for method in methods | ||
| methods.each do |method| | ||
| next if method.to_s == "__send__" || method.to_s == "__id__" |
Member
There was a problem hiding this comment.
I think next if /\A__(?:send|id)__\z/ =~ method is better because of reducing String objects creation.
Contributor
Author
There was a problem hiding this comment.
Sure, that makes sense.
znz
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, send and id were skipped if provided as strings,
but not skipped if provided as symbols.
Fixes Ruby Bug 8855.