Skip to content

Conversation

@jeremyevans
Copy link
Contributor

Do so in a way that is also compatible with previous versions.

@grosser grosser mentioned this pull request Oct 2, 2019
Do so in a way that is also compatible with previous versions.
@jeremyevans jeremyevans force-pushed the keyword-argument-separation branch from 87a29f8 to b2dd340 Compare November 17, 2019 23:33
@eregon
Copy link
Member

eregon commented Nov 18, 2019

Looks fine, any reason not to use ... which would then work forever vs ruby2_keywords which might get removed?

@jeremyevans
Copy link
Contributor Author

@eregon You can't currently use ... with added lead arguments, and forwardable does that.

@piotrmurach
Copy link

Hey, I just came across this issue when testing one of my Ruby gems against 2.7.0-preview2. I virtually had hundreds of warnings due to Forwardable module hash into keyword args coercion. Is this patch going to be released with the final Ruby 2.7.0? Is there anything I could help with on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants