-
Notifications
You must be signed in to change notification settings - Fork 10
JRuby support #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have no idea why the JRuby jobs are stuck. |
|
I have pushed the missing bits for JRuby and rebased on current master. Additional changes from previous review:
This addresses both of @ahorek's review comments. I also tested that the built gem can install and replace the builtin io/wait in JRuby. So it is pretty close now. |
|
Something is still not right with the JRuby builds. |
|
is it missing a |
|
There are no dependencies for CRuby (dev or otherwise) so no bundling is done in any of the builds. I will add the necessary bits for JRuby. |
|
Looks like we have a winner! This can be squashed during merge, or if preferred I can rewrite the commits to better reflect the changes I made. |
|
Pinging maintainers... I believe this is ready to merge and is necessary for JRuby 9.4 to source io-wait (and the net/* libraries that use it) from the gems. High priority for JRuby 9.4 release in the next month or two. |
|
I have updated this from master again. Is there anything else needed to merge? |
|
The omitted test has been un-omitted, since that issue was fixed in JRuby 9.3.1.0 (current is 9.3.3.0). |
Co-authored-by: Pavel Rosický <pdahorek@seznam.cz>
Missing OS and using bare version number '9.3'.
|
I rebased this on master and it will merge now. I'm fine with merge commit or squashed. |
nobu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines seem unnecessary.
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
|
I have addressed all review comments. |
* use case/when for chained ifs * include only necessary files for JRuby
|
🎉 |
|
Thank you both! |
This imports the JRuby code for io/wait, with tests green (see caveat) and hooked up to CI.
One test is skipped on JRuby due to jruby/jruby#6852, which will be fixed in JRuby 9.3.1.0.
This support is needed to release a JRuby-specific io-wait gem, a dependency of net-protocol. Without JRuby support in this gem we can't use any of the other net* gems.