-
Notifications
You must be signed in to change notification settings - Fork 39
Fix InvalidAddressError message #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix InvalidAddressError message #70
Conversation
knu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Thanks!
|
What is the status of this PR? |
|
The current status is CI failure left. As far as I recall, I approved this PR waiting for the tests to finish, and then some of them failed. The failed actions cannot be rerun by now, so you'll have to push again to trigger a new run. I guess Ruby 2.4 & 2.5 on macOS may be removed if they still fail again because those versions are too old. |
melroy89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The errors on Ruby 2.4 & 2.5 on macOS have already been fixed in the following PR: It seems that rebasing this branch should resolve the errors. @ishikawa999 Could you please rebase it? ReferenceI tried rebasing on my forked repository, and the CI passed: (Resolved by test-unit-ruby-core gem v1.0.10) However, since the |
96b3ecd to
c96dbad
Compare
|
Thanks for the review, and sorry I missed your feedback earlier. |
|
@ishikawa999 Thank you for your response. The CI for @knu @hsbt The CI will pass, so could you please check it?
|
|
@hsbt Thank you for merging. |
This pull request will fix issue #60.
Fix to use the
addrvariable that exists instead of the non-existent@addr.