Skip to content

Conversation

@ishikawa999
Copy link
Contributor

@ishikawa999 ishikawa999 commented Apr 27, 2024

This pull request will fix issue #60.
Fix to use the addr variable that exists instead of the non-existent @addr.

@ishikawa999 ishikawa999 requested a review from knu as a code owner April 27, 2024 07:29
Copy link
Member

@knu knu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

@corrupt952
Copy link

@ishikawa999 @knu

What is the status of this PR?
It looks like 65a4c41 was merged last week, so if I re-checkout from master or merging master, the build that is failing on this PR appears to be ready to go through.

@knu
Copy link
Member

knu commented Aug 14, 2024

The current status is CI failure left. As far as I recall, I approved this PR waiting for the tests to finish, and then some of them failed.

The failed actions cannot be rerun by now, so you'll have to push again to trigger a new run.

I guess Ruby 2.4 & 2.5 on macOS may be removed if they still fail again because those versions are too old.

Copy link

@melroy89 melroy89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taketo1113
Copy link
Contributor

taketo1113 commented Oct 10, 2025

The current status is CI failure left. As far as I recall, I approved this PR waiting for the tests to finish, and then some of them failed.

The failed actions cannot be rerun by now, so you'll have to push again to trigger a new run.

I guess Ruby 2.4 & 2.5 on macOS may be removed if they still fail again because those versions are too old.

The errors on Ruby 2.4 & 2.5 on macOS have already been fixed in the following PR:

It seems that rebasing this branch should resolve the errors.

@ishikawa999 Could you please rebase it?

Reference

I tried rebasing on my forked repository, and the CI passed:
https://github.com/taketo1113/ipaddr/actions/runs/18406167879

(Resolved by test-unit-ruby-core gem v1.0.10) However, since the test-unit-ruby-core gem v1.0.9 causes errors on Ruby 2.4 and earlier, this CI run pins the gem to v1.0.7.
This issue has already been fixed in the following PR, and it's expected to be resolved in the next release (1.0.10?) of the test-unit-ruby-core gem:

@ishikawa999 ishikawa999 force-pushed the fix-invalid-address-error-message branch from 96b3ecd to c96dbad Compare October 17, 2025 04:08
@ishikawa999
Copy link
Contributor Author

Thanks for the review, and sorry I missed your feedback earlier.
@taketo1113 I’ve rebased the branch; does it look okay now?

@taketo1113
Copy link
Contributor

taketo1113 commented Oct 17, 2025

@ishikawa999 Thank you for your response.

The CI for ruby/ipaddr hasn’t run yet, but since the CI for ishikawa999/ipaddr is all green, I think it should be fine.
https://github.com/ishikawa999/ipaddr/actions/runs/18582133324

@knu @hsbt The CI will pass, so could you please check it?

The current status is CI failure left. As far as I recall, I approved this PR waiting for the tests to finish, and then some of them failed.
#70 (comment)

@hsbt hsbt merged commit 0603ddb into ruby:master Oct 17, 2025
29 checks passed
@taketo1113
Copy link
Contributor

@hsbt Thank you for merging.
I'm glad because this is the fix I wanted to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants