Skip to content

Conversation

@k0kubun
Copy link
Member

@k0kubun k0kubun commented Oct 6, 2025

@k0kubun k0kubun requested a review from knu as a code owner October 6, 2025 23:43
@k0kubun k0kubun merged commit 4061a67 into ruby:master Oct 6, 2025
18 of 29 checks passed
@k0kubun k0kubun deleted the sync-ruby branch October 6, 2025 23:48
@taketo1113
Copy link
Contributor

It seems that the CI error on Ruby 2.4 is caused by the test-unit-ruby-core gem version 1.0.9.
https://github.com/ruby/ipaddr/actions/runs/18297568280/job/52098942424#step:4:16

Run bundle exec rake test
...
/home/runner/work/ipaddr/ipaddr/vendor/bundle/ruby/2.4.0/gems/test-unit-ruby-core-1.0.9/lib/core_assertions.rb:75:in `require_relative': /home/runner/work/ipaddr/ipaddr/vendor/bundle/ruby/2.4.0/gems/test-unit-ruby-core-1.0.9/lib/envutil.rb:108: syntax error, unexpected keyword_rescue, expecting keyword_end (SyntaxError)
      rescue Timeout::Error
            ^
/home/runner/work/ipaddr/ipaddr/vendor/bundle/ruby/2.4.0/gems/test-unit-ruby-core-1.0.9/lib/envutil.rb:481: syntax error, unexpected keyword_end, expecting end-of-input
...

I have confirmed that the tests pass on Ruby 2.4 after applying the following patch to the test-unit-ruby-core gem:
ruby/test-unit-ruby-core#18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants