Remove redundant argument defaults from some RubyLex methods #502
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods are always called with tokens specified. So their default `@tokens` value is never used and is misleading.
st0012
force-pushed
the
refactor-lexer
branch
from
a274ab1 to
dee85ee
Compare
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jan 12, 2023
methods (ruby/irb#502) * Remove unnecessary parameter defaults These methods are always called with tokens specified. So their default `@tokens` value is never used and is misleading. * Remove unnecessary context default * Require tokens for `RubyLex#check_state`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First 2 commits' argument defaults are not necessary because all of their callers specify the argument's value.
Given that these methods are only used within IRB, I feel leaving these defaults could be misleading.
The last commit is a similar cleanup by making one caller generating tokens beforehand.