Store context in RubyLex #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
force-pushed
the
store-context-in-lexer
branch
from
54a6b8b to
47ca87a
Compare
hasumikin
added a commit
to hasumikin/reline
that referenced
this pull request
Jan 12, 2023
hasumikin
approved these changes
Jan 12, 2023
Collaborator
hasumikin
left a comment
hasumikin
left a comment
There was a problem hiding this comment.
LGTM
I made a related PR ruby/reline#498
Member
Author
|
@hasumikin That's awesome, thank you 👍 |
st0012
force-pushed
the
store-context-in-lexer
branch
from
47ca87a to
b991c8f
Compare
Some background for this refactor: 1. Through a RubyLex instance's lifetime, the context passed to its methods should be the same. Given that `Context` is only initialised in `Irb#initialize`, this should be true. 2. When `RubyLex` is initialised, the context object should be accessible. This is also true in all 3 of `RubyLex.new`'s invocations. With the above observations, we should be able to store the context in `RubyLex` as an instance variable. And doing so will make `RubyLex`'s instance methods easier to use and maintain.
st0012
force-pushed
the
store-context-in-lexer
branch
from
b991c8f to
bdfa4b7
Compare
hasumikin
added a commit
to ruby/reline
that referenced
this pull request
Jan 14, 2023
* Correspond to refactored RubyLex ref: ruby/irb#503 * Fix test_yamatanooroti
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jan 14, 2023
(ruby/reline#498) * Correspond to refactored RubyLex ref: ruby/irb#503 * Fix test_yamatanooroti
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some background/assumptions for this refactor:
Through a RubyLex instance's lifetime, the context passed to its methods should be the same. Given that
Contextis only initialised once inIrb#initialize, this should be true.When
RubyLexis initialised, the context object should be accessible. This is also true in all 3 ofRubyLex.new's invocations.With the above observations, we should be able to store the context in
RubyLexas an instance variable. And doing so will makeRubyLex's instance methods easier to use and maintain.