Support inspecting BasicObject #541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
commented
Mar 13, 2023
| class ColorPrinter < ::PP | ||
| METHOD_IS_A = Object.instance_method(:is_a?) | ||
| METHOD_RESPOND_TO = Object.instance_method(:respond_to?) | ||
| METHOD_INSPECT = Object.instance_method(:inspect) |
Member
Author
There was a problem hiding this comment.
I know we already have store the method object in other places (e.g. inspector.rb). But I don't want to create dependencies between files just to reuse this as it's easy to find duplications later on.
tompng
approved these changes
Mar 13, 2023
Member
tompng
left a comment
tompng
left a comment
There was a problem hiding this comment.
irb(main):001:0> BasicObject.new
=> #<BasicObject:0x0000000103e59788>
irb(main):002:0> [BasicObject.new]
=> [#<BasicObject:0x0000000103eba038>]
🎉 Looks good to me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inspecting
BasicObjectin irb, the default inspectorppwould raise an exception because it callsis_a?on the object. We should helpppsupportBasicObject(if that's possible), but in the meantime we can also mitigate the problem from irb.Closes #540