Skip to content

Fix indent test and output sequence test for new reline #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tompng merged 1 commit into from
Mar 24, 2024
Merged

Fix indent test and output sequence test for new reline #908

tompng merged 1 commit into from
Mar 24, 2024

Conversation

@tompng
Copy link
Member

@tompng tompng commented Mar 22, 2024 •
edited by st0012
Loading

CI is failing after ruby/reline#614 is merged.

Indent is changed/fixed

For example, pasting "a\n .b\n .c":

Reline 0.4.2
> a
>   .b
> .c█

Reline 0.5.0.pre.1
> a
>   .b
>   .c█

This pull request changes the test to pass with both version by using "a\n .b\n .c\n.d".

st0012
st0012 reviewed Mar 22, 2024
View reviewed changes
@tompng tompng force-pushed the fix_test_reline_0.5.0 branch from ab7a9c6 to f5480b2 Compare March 23, 2024 02:28
@tompng tompng force-pushed the fix_test_reline_0.5.0 branch from f5480b2 to 96dbd28 Compare March 24, 2024 03:35
@tompng tompng merged commit 7c16ce0 into ruby:master Mar 24, 2024
@tompng tompng deleted the fix_test_reline_0.5.0 branch March 24, 2024 12:54
matzbot pushed a commit to ruby/ruby that referenced this pull request Mar 24, 2024
@tompng @matzbot
[ruby/irb] Fix indent test for new reline
82f4cff 
(ruby/irb#908)

ruby/irb@7c16ce033e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@st0012 st0012 st0012 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tompng @st0012