Skip to content

Restore MAIN_CONTEXT correctly #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
st0012 merged 1 commit into from
Apr 30, 2024
Merged

Restore MAIN_CONTEXT correctly #937

st0012 merged 1 commit into from
Apr 30, 2024

Conversation

@tompng
Copy link
Member

@tompng tompng commented Apr 27, 2024

Fixes #650

@st0012 st0012 added the bug Something isn't working label Apr 30, 2024
st0012
st0012 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@st0012 st0012 merged commit c41f460 into ruby:master Apr 30, 2024
matzbot pushed a commit to ruby/ruby that referenced this pull request Apr 30, 2024
@tompng @matzbot
[ruby/irb] Restore MAIN_CONTEXT correctly
8fb430c 
(ruby/irb#937)

ruby/irb@c41f460a70
@tompng tompng deleted the current_context_safe_restore branch May 3, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@st0012 st0012 st0012 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IRB doesn't restore context after leaving the nested session

2 participants

@tompng @st0012