Skip to content

Conversation

@headius
Copy link
Contributor

@headius headius commented Mar 26, 2024

These methods have been deprecated for some time and we would like to delete them.

See jruby/jruby#9143 and jruby/jruby#8149.

These methods have been deprecated for some time and we would like
to delete them.

See jruby/jruby#9143 and jruby/jruby#8149.
@headius headius force-pushed the no_19_jruby_methods branch from 818d935 to a480682 Compare March 26, 2024 01:45
@headius
Copy link
Contributor Author

headius commented Mar 26, 2024

The byteListToDouble19 equivalent is now byteListToDouble, but rather than backport that I have used the implementation it contains.

@headius
Copy link
Contributor Author

headius commented Mar 26, 2024

This appears to be passing on all JRuby versions back to 9.1, and can be released any time.

We will want this in the wild for a while before we can proceed with removing the 19 versions, which mostly will happen in JRuby 10 (later this year) and a subsequent major release.

headius added a commit to jruby/jruby that referenced this pull request Mar 26, 2024
@hsbt hsbt merged commit 84b7517 into ruby:master Apr 3, 2024
@headius headius deleted the no_19_jruby_methods branch April 3, 2024 12:30
@headius
Copy link
Contributor Author

headius commented Apr 3, 2024

@hsbt Thank you for merging! We can release this any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants