Skip to content

Fix the Logger::Formatter documentation #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hsbt merged 1 commit into from
Oct 7, 2022
Merged

Fix the Logger::Formatter documentation #79

hsbt merged 1 commit into from
Oct 7, 2022

Conversation

@liijunwei
Copy link
Contributor

@liijunwei liijunwei commented Aug 20, 2022

Fix #78

@liijunwei
Copy link
Contributor Author

liijunwei commented Aug 20, 2022

Logger::Formatter::DatetimeFormat is "%Y-%m-%dT%H:%M:%S.%6N" and it doesn't include Timezone info.

If timezone info is required , we better add %Z formatter

e.g.

Time.now.strftime("%Y-%m-%dT%H:%M:%S.%6N %Z")
=> "2022-08-20T23:15:47.742414 CST"

@hsbt hsbt merged commit 019c6cf into ruby:master Oct 7, 2022
@liijunwei liijunwei deleted the fixdoc branch December 31, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inaccurate documentation

2 participants

@liijunwei @hsbt