fix :unitary? and add :adjoint#14
Closed
AlessandroMinali wants to merge 1 commit intoruby:masterfrom
AlessandroMinali:unitary_matrix
Closed
fix :unitary? and add :adjoint#14AlessandroMinali wants to merge 1 commit intoruby:masterfrom AlessandroMinali:unitary_matrix
AlessandroMinali wants to merge 1 commit intoruby:masterfrom
AlessandroMinali:unitary_matrix
Conversation
Member
|
Author
|
Sure, feel free to take this over. |
marcandre
added a commit
that referenced
this pull request
Apr 30, 2020
marcandre
added a commit
that referenced
this pull request
Apr 30, 2020
Patch adapted from Alessandro Minali; #14
marcandre
added a commit
that referenced
this pull request
Apr 30, 2020
marcandre
added a commit
that referenced
this pull request
Apr 30, 2020
Patch adapted from Alessandro Minali; #14
marcandre
added a commit
that referenced
this pull request
Apr 30, 2020
marcandre
added a commit
that referenced
this pull request
Apr 30, 2020
Patch adapted from Alessandro Minali
Member
|
Turns out indices Same issue with I'll try to see how to make a release tomorrow... Thanks again for raising the issue! |
marcandre
added a commit
that referenced
this pull request
May 1, 2020
marcandre
added a commit
that referenced
this pull request
May 1, 2020
Patch adapted from Alessandro Minali
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:unitary?is currently not working(since 2011?). Also added tests.Example:
Verification of unitary matrix