Fix connection leak when the thread is interrupted by Thread#kill etc. #27
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyevans
approved these changes
Dec 15, 2023
Contributor
jeremyevans
left a comment
jeremyevans
left a comment
There was a problem hiding this comment.
I reviewed the related code, and it doesn't yield or appear to pass control to user code, so non-local flow control should not be a consideration, and this approach should be fine.
| def transfercmd(cmd, rest_offset = nil) # :nodoc: | ||
| if @passive | ||
| host, port = makepasv | ||
| succeeded = false |
Contributor
There was a problem hiding this comment.
This line is not actually needed. However, I have no problem with it if you using it to be explicit.
Member
Author
There was a problem hiding this comment.
Thanks for your comment.
I'd like to initialize succeeded to clarify the intention.
ioquatix
approved these changes
Dec 15, 2023
Member
ioquatix
left a comment
ioquatix
left a comment
There was a problem hiding this comment.
LGTM. It's interesting that a trivial fix was actually non-trivial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by @ioquatix in #24 (comment)