✨ Minor updates to SASL::Authenticators API #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since they haven't been in any release yet, `SASL.initial_response?` and `SASL.done?` have been removed without deprecation. The logic has been moved directly into `Net::IMAP#authenticate` (for now). Implementing `#initial_response?` is still optional. But, to simplify the tests, `#initial_response? => false` was added to all of the deprecated SASL mechanisms.
Reversed the `use_defaults` default, and added another option for `use_deprecated`.
Abstracts running a command with a continuation handler. In the base specifications (both RFC-3501 and RFC-9051), the only command to need this is `AUTHENTICATE`. The only other continuations are for sending literals, which are simple command arguments. Are there any IMAP extensions that use continuations in this way? Even with only one command, this still makes that code a little more readable. More importantly, it also simplifies the creation of a generic SASL protocol adapter, for use by `net-sasl`, `net-pop`, and others.
This was referenced Oct 3, 2023
Closed
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making some minor API changes to SASL::Authenticators. This class hasn't been included in a release yet, so there's no need to deprecate anything... if the change is made before the release. :)