Add :max_redirects option #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyevans
requested changes
Nov 9, 2023
Contributor
jeremyevans
left a comment
jeremyevans
left a comment
There was a problem hiding this comment.
Thanks for working on this. I like this idea, I just have a couple of requested changes.
lib/open-uri.rb
Outdated
| :ftp_active_mode => false, | ||
| :redirect => true, | ||
| :encoding => nil, | ||
| :max_redirects => nil, |
Contributor
There was a problem hiding this comment.
I think we should set a maximum number of redirects by default to avoid infinite redirect loops. Maybe 64?
lib/open-uri.rb
Outdated
| uri = redirect | ||
| raise "HTTP redirection loop: #{uri}" if uri_set.include? uri.to_s | ||
| uri_set[uri.to_s] = true | ||
| raise "Too many redirects" if max_redirects && uri_set.size > max_redirects |
Contributor
There was a problem hiding this comment.
We probably should have a specific exception class for this, so users that want to catch this don't have to rescue RuntimeError.
Contributor
Author
|
Thanks @jeremyevans, updated based on the feedback. |
jeremyevans
approved these changes
Nov 10, 2023
Contributor
Author
|
Thanks @jeremyevans and @hsbt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to limit the number of redirects.
There's no limit by default for backward compatibility, but I think it'd be good for include one in a future version.