feat: allow option to pass user specified SSL version to use during communication #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation. Allow versions are OpenSSL::SSL::SSLContext::METHODS
nishantactive
changed the title
Contributor
|
Hi, thanks for making a PR! Is it possible to add a test which exercises the setting? (E.g. the "silent no action when given bad data" behaviour, could be covered by a test.) |
Contributor
Author
|
Thank you. Have added suggested test case. |
Member
|
👍 Sorry to late response. It seems reasonable. |
Member
|
I'm sorry I wasn't following this PR, but I'm against this change. It should be accessors for OpenSSL::SSL::SSLContext#{min,max}_version= and not for #ssl_version= because
I will come up with a PR to update it to use OpenSSL::SSL::SSLContext#{min,max}_version=. |
rhenium
reviewed
Oct 7, 2022
| http.use_ssl = true | ||
| http.verify_mode = options[:ssl_verify_mode] || OpenSSL::SSL::VERIFY_PEER | ||
| http.ssl_version = options[:ssl_version] if options[:ssl_version] && | ||
| OpenSSL::SSL::SSLContext::METHODS.include?(options[:ssl_version]) |
Member
There was a problem hiding this comment.
Is there any reason why it ignores an invalid value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation do not give option to select a specific SSL version to use during communication. Sometime, servers have requirement of a specific SSL version to use and it rejects connection initated by open-uri.
Added an optional option called ssl_version when correctly specified as one of the values returned by this method OpenSSL::SSL::SSLContext::METHODS, open method uses this ssl version to establish connection.