Skip to content

Conversation

@BurdetteLamar
Copy link
Member

Will need examples, and perhaps more text. But first: is this text correct?

@BurdetteLamar BurdetteLamar marked this pull request as draft October 25, 2023 19:08
@BurdetteLamar BurdetteLamar added the documentation Improvements or additions to documentation label Oct 25, 2023
BurdetteLamar and others added 2 commits November 5, 2023 09:27
Co-authored-by: Peter Zhu <peter@peterzhu.ca>
Co-authored-by: Peter Zhu <peter@peterzhu.ca>
Copy link
Member

@peterzhu2118 peterzhu2118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good. Is there anything you want to address before changing it to a non-draft PR?

@BurdetteLamar
Copy link
Member Author

I think it looks good. Is there anything you want to address before changing it to a non-draft PR?

Yes. I think the present discussion can be improved (under way) and code examples are needed.

@BurdetteLamar
Copy link
Member Author

@peterzhu2118, ready to merge. Do the honors?

@peterzhu2118 peterzhu2118 marked this pull request as ready for review November 10, 2023 17:14
@peterzhu2118 peterzhu2118 merged commit 9f3f5d0 into ruby:master Nov 10, 2023
matzbot pushed a commit to ruby/ruby that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants