Skip to content

Conversation

@BurdetteLamar
Copy link
Member

No description provided.

@BurdetteLamar BurdetteLamar added the documentation Improvements or additions to documentation label Nov 18, 2023
lib/open3.rb Outdated
# ...
# }
# :call-seq:
# Open3.pipeline_w([env, ] *cmds, options = {}) -> array_of_statuses
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Open3.pipeline_w([env, ] *cmds, options = {}) -> array_of_statuses
# Open3.pipeline_w([env, ] *cmds, options = {}) -> [first_stdin, wait_threads]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

lib/open3.rb Outdated
# see {Execution Environment}[https://docs.ruby-lang.org/en/master/Process.html#module-Process-label-Execution+Environment].
#
# If the last argument is a hash, it becomes trailing argument +options+
# in each call to Process.spawn'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# in each call to Process.spawn'
# in each call to Process.spawn;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Co-authored-by: Peter Zhu <peter@peterzhu.ca>
@peterzhu2118 peterzhu2118 merged commit 4c9e749 into ruby:master Nov 19, 2023
matzbot pushed a commit to ruby/ruby that referenced this pull request Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants