Skip to content

We should use VERSION instead of Version constant #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsbt merged 1 commit into from
Oct 31, 2025
Merged

We should use VERSION instead of Version constant #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/optparse.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,8 @@
#
class OptionParser
# The version string
OptionParser::Version = "0.7.0.dev.2"
VERSION = "0.7.0.dev.2"
Version = VERSION # for compatibility

# :stopdoc:
NoArgument = [NO_ARGUMENT = :NONE, nil].freeze
Expand Down
2 changes: 1 addition & 1 deletion optparse.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
name = File.basename(__FILE__, ".gemspec")
version = ["lib", Array.new(name.count("-")+1, "..").join("/")].find do |dir|
break File.foreach(File.join(__dir__, dir, "#{name.tr('-', '/')}.rb")) do |line|
/^\s*OptionParser::Version\s*=\s*"(.*)"/ =~ line and break $1
/^\s*VERSION\s*=\s*"(.*)"/ =~ line and break $1
end rescue nil
end

Expand Down
2 changes: 1 addition & 1 deletion rakelib/version.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ class << (helper = Bundler::GemHelper.instance)
def update_version
File.open(mainfile, "r+b") do |f|
d = f.read
if d.sub!(/^(\s*OptionParser::Version\s*=\s*)".*"/) {$1 + gemspec.version.to_s.dump}
if d.sub!(/^(\s*VERSION\s*=\s*)".*"/) {$1 + gemspec.version.to_s.dump}
f.rewind
f.truncate(0)
f.print(d)
Expand Down