Skip to content

Conversation

@ko1
Copy link
Contributor

@ko1 ko1 commented Dec 8, 2021

To fix the issue https://bugs.ruby-lang.org/issues/18243
we need to make sure the Proc's self is shareable.
These procs are used by define_method and it doesn't use
Proc's self, so nil is enough.

To fix the issue https://bugs.ruby-lang.org/issues/18243
we need to make sure the Proc's self is shareable.
These procs are used by `define_method` and it doesn't use
Proc's self, so `nil` is enough.
@marcandre
Copy link
Member

Thanks for the PR. Would the current test suite of ostruct fail once ruby/ruby#5232 is merged?

@ko1
Copy link
Contributor Author

ko1 commented Dec 8, 2021

ruby/ruby#5232 contains same patch for ruby/ruby (to prevent the failure).

So the answer is:

  • YES, this patch is needed.
  • No, this patch is contained in the ruby/ruby's PR.

@ko1
Copy link
Contributor Author

ko1 commented Dec 8, 2021

if this PR is merged quickly and apply to ruby/ruby, I'll rebase ruby/ruby#5232 on it.

@marcandre marcandre merged commit 7cb707c into ruby:master Dec 8, 2021
@marcandre
Copy link
Member

Done, and pushed to main repo too as 9c26931635

@ko1
Copy link
Contributor Author

ko1 commented Dec 9, 2021

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants