Fix class and method as attribute names #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoroth
added a commit
to marcoroth/stimulus_reflex
that referenced
this pull request
Jan 18, 2022
See: ruby/ostruct#37 Co-Authored-By: Ladislav Gallay <ladislav.gallay@lentil.sk>
marcoroth
added a commit
to marcoroth/stimulus_reflex
that referenced
this pull request
Jan 18, 2022
See: ruby/ostruct#37 Co-Authored-By: Ladislav Gallay <ladislav.gallay@lentil.sk>
3 tasks
Member
|
Great catch, thank you! |
Member
|
Released as 0.5.3 |
marcoroth
added a commit
to stimulusreflex/stimulus_reflex
that referenced
this pull request
Jan 20, 2022
…es (#569) See: ruby/ostruct#37 Co-Authored-By: Ladislav Gallay <ladislav.gallay@lentil.sk> Co-authored-by: Ladislav Gallay <ladislav.gallay@lentil.sk>
dobrite
pushed a commit
to planningcenter/balto-brakeman
that referenced
this pull request
Jun 30, 2022
The OpenStruct implementation differs between Ruby 2.7 and 3.1. The latter comes with OpenStruct 0.5.2. That version has a bug that was fixed [here](ruby/ostruct#37). The TL;DR of the impact of that bug in this repo is that brakeman includes JSON with an attribute named `class`. This shadows the normal `class` method and causes `self.class.ancestors` to blow up. The fix uses the aliased `class!` method to do the Right Thing™.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.